Skip to content

[Build System: update-checkout] avoid multiprocessing when n is 1 #78896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Build System: update-checkout] avoid multiprocessing when n is 1 #78896

wants to merge 3 commits into from

Conversation

hnrklssn
Copy link
Contributor

There's no need to fiddle with locks etc. when there's no actual parallelism going on.

@hnrklssn
[Build System: update-checkout] avoid multiprocessing when n is 1
8cea2e5 
There's no need to fiddle with locks etc. when there's no actual
parallelism going on.
@hnrklssn hnrklssn requested a review from shahmishal as a code owner January 24, 2025 23:24
@hnrklssn
Copy link
Contributor Author

@swift-ci please smoke test

@hnrklssn
Copy link
Contributor Author

For context, this helped me work around an issue where I kept getting stuck waiting on a lock (for reasons I don't know).

MaxDesiatov
MaxDesiatov reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but lack of testing worries me. I'm not proficient enough with Python to suggest a concrete testing strategy though.

@MaxDesiatov MaxDesiatov added python Flag: Python source code update-checkout Area → utils: the `update-checkout` script needs tests Flag: Issue is fixed but needs tests / PR needs tests labels Jan 27, 2025
@hnrklssn
Copy link
Contributor Author

Seems fine, but lack of testing worries me. I'm not proficient enough with Python to suggest a concrete testing strategy though.

Does update-checkout have tests?

@MaxDesiatov
Copy link
Contributor

It does seem to have some tests here https://github.com/swiftlang/swift/tree/main/utils/update_checkout/tests

hnrklssn added 2 commits March 5, 2025 17:55
@hnrklssn
[update-checkout] test single threaded checkout
10ec6eb
@hnrklssn
[update-checkout] don't sign commits in mock repo
9b0a356 
The mock repo is configured with the [email protected] email address.
If the user has globally configured git to sign commits this won't match
the signature, preventing the tests from running properly.
@hnrklssn
Copy link
Contributor Author

hnrklssn commented Mar 6, 2025

@swift-ci please smoke test

@hnrklssn
Copy link
Contributor Author

hnrklssn commented Mar 6, 2025

@MaxDesiatov Sorry about the delay. Added some single threaded versions of the existing tests. Let me know if you have any other comments.

@AnthonyLatsis AnthonyLatsis removed the needs tests Flag: Issue is fixed but needs tests / PR needs tests label Mar 6, 2025
@MaxDesiatov
Copy link
Contributor

@swift-ci smoke test linux

MaxDesiatov
MaxDesiatov approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaxDesiatov MaxDesiatov enabled auto-merge March 6, 2025 09:50
@AnthonyLatsis AnthonyLatsis requested a review from edymtt March 6, 2025 20:50
AnthonyLatsis
AnthonyLatsis reviewed Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait for a review from Eric Evan too. Feel free to ping them if the PR stalls.

@hnrklssn
Copy link
Contributor Author

hnrklssn commented Mar 6, 2025

@swift-ci smoke test linux

@AnthonyLatsis AnthonyLatsis requested review from etcwilde and removed request for edymtt March 7, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyLatsis AnthonyLatsis AnthonyLatsis left review comments

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde is a code owner

Assignees
No one assigned
Labels
python Flag: Python source code update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hnrklssn @MaxDesiatov @AnthonyLatsis