[update-checkout] Skip fetching tags when --skip-tags is passed #79814
Conversation
The existing --skip-tags option only affected cloning new repos. This skips fetching tags in already cloned repos as well.
hnrklssn
added
python
|
@swift-ci please test |
AnthonyLatsis
added
the
utils
|
@swift-ci python lint |
| shell.run(["git", "fetch", "--recurse-submodules=yes", | ||
| "--tags"], | ||
| f"{checkout_target}:{checkout_target}"], | ||
| echo=True, prefix=prefix) |
There was a problem hiding this comment.
The refspec will not work with hashes or tags, and I believe it is better not to proactively create local branches if the target is a branch. I also think we still want to respect skip_tags here.
There was a problem hiding this comment.
Hmm yeah, this bit turned out to be trickier than I expected... The method for fetching a single tag is different from fetching a single branch, but it doesn't seem like the script knows whether checkout_target is a tag or a branch. Since this fetch is explicitly done because checkout_target wasn't found locally, it seems like simply skipping --tags here when --skip-tags is passed will lead to more errors than not. So it'd be good if we could fetch a just a single tag when needed.
|
Is this testable at all? |
|
Totally is, we have the infrastructure. I even have a test for this exact case in a dusty worktree along with a bunch of others that I have been planning to stage in for a while. |
AnthonyLatsis
requested review from
al45tair,
edymtt and
etcwilde
and removed request for
edymtt and
al45tair
The existing --skip-tags option only affects cloning new repos. This skips fetching tags in already cloned repos as well.