[cxx-interop] Temporarily exclude CxxSetToCollection benchmark from the build #81145
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-hui
reviewed
Apr 28, 2025
egorzhdan
force-pushed
the
egorzhdan/bench-disable
branch
from
7437b2e to
8edd8d2
Compare
…he build This is needed to unblock nightly toolchains, which are currently failing to build with an assertion: ``` swift-frontend: /home/build-user/build/buildbot_linux/llvm-linux-x86_64/tools/clang/include/clang/AST/TypeNodes.inc:79: TypeInfo clang::ASTContext::getTypeInfoImpl(const Type *) const: Assertion `!T->isDependentType() && "should not see dependent types here"' failed. ``` rdar://150067288
egorzhdan
force-pushed
the
egorzhdan/bench-disable
branch
from
8edd8d2 to
85d6be5
Compare
|
@swift-ci please benchmark |
|
@swift-ci please smoke test |
|
@j-hui good point! I disabled the other two, let's see if anything else is failing. |
j-hui
approved these changes
Apr 28, 2025
|
@swift-ci please smoke test macos platform |
1 similar comment
|
@swift-ci please smoke test macos platform |
|
@swift-ci smoke test macos |
|
@swift-ci smoke test macos |
@j-hui the benchmarks can be built as a Swift Package, in which case CMake flags won't be applied. This way we can be certain that the problematic code won't be built regardless of the build system used. |
|
@egorzhdan does this need a cherry-pick for 6.2? |
j-hui
added a commit
to j-hui/swift
that referenced
this pull request
May 1, 2025
…k from the build (swiftlang#81145)" This reverts commit 86c30d6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to unblock nightly toolchains, which are currently failing to build with an assertion:
rdar://150067288