[embedded] Require swift_stdlib_no_asserts in test/embedded/traps-fatalerror-ir.swift #81154
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
MaxDesiatov,
glessard,
phausler,
rauhul,
eeckstein and
dschaefer2
|
@swift-ci please test |
rauhul
approved these changes
Apr 29, 2025
|
Do you need to mark the test as stable now/unmark as flakey or something? |
|
Hm, no I don't think so? @glessard has reported the issue as a blocker for one of his PRs, which hasn't been merged yet. The test isn't actually "flaky" in the "non-deterministic" sense, it is just very sensitive to the stdlib Swift code on the fatalError() path. The expectations of this test only match non-assert builds of the stdlib, which is the only way we ship the stdlib for production use cases anyway. |
glessard
approved these changes
Apr 29, 2025
|
@swift-ci please test Linux platform |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81085.