6.2: CMake: add explicit dependency to _Builtin_float to targets...
#81165
+98
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation` This will avoid errors in CI when the latter ones are scheduled before the former. Addresses rdar://149558141 (cherry picked from commit 231a9d9)
|
@swift-ci please test |
compnerd
approved these changes
Apr 29, 2025
shahmishal
approved these changes
Apr 30, 2025
... that would import that as a result of importing Darwin from the SDK. Amend my previous change to Differentiation and Distributed in this sense. Addresses rdar://150400049 (cherry picked from commit 8c7e855)
|
@swift-ci please test |
edymtt
changed the title
_Builtin_float dependency to Distributed and Synchronization
edymtt
changed the title
_Builtin_float to targets...
|
@swift-ci please test Windows |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... that would import that as a result of importing Darwin from the SDK.
Ensure
Distributed,Synchronizationand other targets that import Darwin have a dependency on_Builtin_floatas well (which Darwin re-exports) to avoid build errors (especially when doing a clean build)Current CMake build logic used to build the standard library
rdar://149558141& 150400049
Add
_Builtin_floatdependency toDistributedandSynchronization#81141CMake: add explicit dependency to _Builtin_float to targets... #81241
Low - this only affects the build ordering, not the content of the libraries; in case I fat fingered the changes, we will keep hitting the same build failures with the same frequency
build.ninjato ensure that the new edges are added if_Builtin_floatis configured to build@etcwilde , @compnerd, @ian-twilightcoder