Skip to content

[6.2] preset: build swift with no assertion for swiftpm on linux #81513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented May 14, 2025

To work around, do not build swift with assertions for the SwiftPM on linux.

(cherry picked from commit 3c363d5)

Based on: #81217

Explanation:
There is a runtime issue (#81144) that caused a runtime failure. We updated the SwiftPM preset to workaround the issue so we can get Swift Testing in the project.

Scope:
This modified a linux smoke test preset used by, at a minimum, SwiftPM. The official toolchain builds don't build using assertions, so it was decided to not build linux with assertions (at least the swift standard lib)

Issues:
N/A

Original PRs:
#81217

Risk:
Low risk from a toolchain perspective as the modified preset is likely only used by SwiftPM linux smoke tests.

Testing:
Run this PR against swiftlang/swift-package-manager#8608.

Reviewers:
N/A

To work around swiftlang#81144, do not
build swift with assertions for the SwiftPM on linux.

(cherry picked from commit 3c363d5)
@bkhouri bkhouri requested a review from a team as a code owner May 14, 2025 18:02
@bkhouri
Copy link
Contributor Author

bkhouri commented May 14, 2025

@swift-ci test smoke

@bkhouri
Copy link
Contributor Author

bkhouri commented May 14, 2025

@swift-ci test

@bkhouri bkhouri changed the title preset: build swift with no assertion for swiftpm on linux [6.2] preset: build swift with no assertion for swiftpm on linux May 14, 2025
@bkhouri bkhouri enabled auto-merge May 14, 2025 18:06
@bkhouri
Copy link
Contributor Author

bkhouri commented May 14, 2025

@bkhouri bkhouri merged commit 245514c into swiftlang:release/6.2 May 15, 2025
5 checks passed
@bkhouri bkhouri deleted the t/6.2/disable_assertion branch May 15, 2025 03:32
bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request May 15, 2025
Swift Testing was disabled to due to swiftlang/swift#81144.
However, a workaround was applied to the SwiftPM linux smoke test preset
to enabled swift-testing by not building Swift Standard library with
assertions.  See swiftlang/swift#81513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants