[Swiftify] add debug logs for safe interop #81663
Open
+49
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrklssn
requested review from
Xazax-hun,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci please smoke test |
j-hui
approved these changes
May 21, 2025
There was a problem hiding this comment.
This LGTM, but I'm not sure familiar with what conventions are around inserting normally-inert debug statements like this in the Swift compiler source, so I advise waiting for at least one more approval from someone with more experience in this code base than me.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some dynamically togglable debug logs for the
swiftifyfunction in the ClangImporter under-Xllvm -debug-only=safe-interop-wrappers, and for the_SwiftifyImportmacro under-Xllvm -debug-only=swiftify-import