[6.2 🍒][Dependency Scanning][C++ Interop] Remap lookup of Clang module CxxStdlib to std
#81682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tdlib' to 'std' Otherwise querying this clang module, e.g. from the corresponding Swift overlay's underlying module import, will fail, since no such module exists. Resolves rdar://151718115
artemcm
added
c++ interop
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #81651
Explanation: Ensure we do not directly lookup clang module
CxxStdlib, because one does not exist. Instead, various components of the compiler remap this lookup to a Clang module calledstd. This adds one such missing remap.Scope: Builds with Explicitly-Built modules and C++Interop both enabled which bring in the Swift overlay of the C++ standard library (
CxxStdlib)Risk: Low, this code change should only affect scenarios which were previously guaranteed to fail and should not affect other code.
Problem: rdar://151718115
Reviewed By: @cachemeifyoucan, @j-hui
Original PR: [Dependency Scanning][C++ Interop] Remap lookup of Clang module
CxxStdlibtostd#81651