SIL: define mark_dependence_addr to read and write to its address operand
#81684
+29
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perand This prevents simplification and SILCombine passes to remove (alive) `mark_dependence_addr`. The instruction is conceptually equivalent to ``` %v = load %addr %d = mark_dependence %v on %base store %d to %addr ``` Therefore the address operand has to be defined as writing to the address.
|
@swift-ci smoke test |
|
@swift-ci smoke test macos |
atrick
reviewed
May 22, 2025
| @@ -253,6 +253,9 @@ bool noncopyable::memInstMustReinitialize(Operand *memOper) { | |||
| auto *CAI = cast<ExplicitCopyAddrInst>(memInst); | |||
| return CAI->getDest() == address && !CAI->isInitializationOfDest(); | |||
| } | |||
| case SILInstructionKind::MarkDependenceAddrInst: { | |||
| return true; | |||
There was a problem hiding this comment.
IIUC memInstMustReinitialize should only be true for the address operand of mark_dependence_addr. I don't think a simple read of the base qualifies.
There was a problem hiding this comment.
That was my first try. But the move-only checker crashes if it only returns true for address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents simplification and SILCombine passes to remove (alive)
mark_dependence_addr. The instruction is conceptually equivalent toTherefore the address operand has to be defined as writing to the address.