Skip to content

Re-apply "Tests: enable Swift PM tests in Windows toolchain build"" #82274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Re-apply "Tests: enable Swift PM tests in Windows toolchain build"" #82274

wants to merge 2 commits into from
+2 −2

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Jun 16, 2025 •
edited
Loading

Reverts #82265, which re-applies #80405

Enable the SwiftPM tests in the Windows toolchain build to get extra confidence the change did not introduce any regression on the Windows platform.

In addition to the re-application of #80405, execute SwiftPM tesst in parallel

Fixes: swiftlang/swift-package-manager#8895

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 16, 2025

@swift-ci smoke test

1 similar comment
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 17, 2025

@swift-ci smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 18, 2025

Windows platform build failed with Test Case 'PrepareForIndexTests.testEnaBuild timed out (after 60 minutes). Marking the build as aborted.

Trying again

@swift-ci smoke test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 19, 2025

Windows Platform build failed with Test Case 'VersionSetSpecifierTests.testPrereleases' started at 2025-06-18 23Build timed out (after 60 minutes). Marking the build as aborted.

Between this and the previous execution, the test that hangs in non-deterministic.

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 20, 2025

@swift-ci smoke test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 21, 2025 •
edited
Loading

without code changes, the Windows platform build failed

Test Case 'ManifestEditTests.testAddPackageDependencyExistingNoComma' started at 2025-06-21 02:46:51.493

C:\Users\swift-ci\jenkins\workspace\swift-PR-windoBuild timed out (after 60 minutes). Marking the build as aborted.

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 30, 2025

@swift-ci test windows

1 similar comment
@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 2, 2025

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 2, 2025

swiftlang/swift-package-manager#8891

@swift-ci test

@bkhouri bkhouri marked this pull request as ready for review July 2, 2025 19:54
@bkhouri bkhouri requested a review from compnerd as a code owner July 2, 2025 19:54
@compnerd compnerd requested a review from shahmishal July 2, 2025 19:55
@compnerd
Copy link
Member

compnerd commented Jul 2, 2025

In its current state, this is adding ~65m to the overall test time, which might be a bit excessive. I have a set of patches up which need some help to get merged, but bring this time down to ~8m.

@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 2, 2025

In its current state, this is adding ~65m to the overall test time, which might be a bit excessive. I have a set of patches up which need some help to get merged, but bring this time down to ~8m.

I'm in favour of submitting this, once the test are passing, and then working on the other changes to bring the time down. This will ensure other changes that execute this script will execute the SwiftPM tests as well, helping to ensure regressions are not introduced.

Can you please share the PRs that bring this time down?

@compnerd
Copy link
Member

compnerd commented Jul 3, 2025

Sure, the changes are:

@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 4, 2025

Adding comment for automatic GitHub traceability.

This PR fixes: swiftlang/swift-package-manager#8895

@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 4, 2025

swiftlang/swift-package-manager#8891

@swift-ci smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 7, 2025

swiftlang/swift-package-manager#8899

@swift-ci test

bkhouri and others added 2 commits July 7, 2025 15:15
@bkhouri
Re-apply "Tests: enable Swift PM tests in Windows toolchain build"
0ae55f1 
Reverts #82265, which re-applies #80405

Enable the SwiftPM tests in the Windows toolchain build to get extra
confidence the change did not introduce any regression on the Windows
platform.

Fixes: swiftlang/swift-package-manager#8895
@bkhouri
Windows: execute SwiftPM tesst in parallel
0bb3d3d
@bkhouri bkhouri force-pushed the revert-82265-revert-80405-t/main/update_swiftpm_presets branch from 34cd647 to 0bb3d3d Compare July 7, 2025 19:17
@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 7, 2025

swiftlang/swift-package-manager#8899

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 7, 2025

swiftlang/swift-package-manager#8899

@swift-ci smoke test

@bkhouri bkhouri mentioned this pull request Jul 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd Awaiting requested review from compnerd compnerd is a code owner

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable the SPM test suite on Windows
2 participants
@bkhouri @compnerd