Skip to content

Remove cmake from Brewfile #83060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jul 15, 2025

Brewfile is not used on CI and is purely a contributor experience helper for at-desk builds. We're seeing multiple build failures with CMake 4.0 on macOS: e.g. SwiftPM bootstrapping issues. build-script will always build a fixed version of CMake that's known to work, if preinstalled one is not found. Let's reduce the chances for confusion by not preinstalling CMake for those who use Brewfile.

We're seeing multiple build failures with CMake 4.0 on macOS: e.g. SwiftPM bootstrapping issues. `build-script` will always build a fixed version of CMake that's known to work, if preinstalled one is not found. Let's reduce the chances for confusion by not preinstalling CMake for those who use `Brewfile`.
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

@@ -1,3 +1,2 @@
brew "cmake"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brew allows selecting a specific version doesn't it? Can we just pin it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not, at least for CMake only latest version is provided:

❯ brew install [email protected]
Warning: No available formula with the name "[email protected]". Did you mean cmake?
==> Searching for similarly named formulae and casks...
==> Formulae
cmake ✔

To install cmake ✔, run:
  brew install cmake ✔

❯ brew install [email protected]
Warning: No available formula with the name "[email protected]".
==> Searching for similarly named formulae and casks...
Error: No formulae or casks found for [email protected].

❯ brew install cmake@3
Warning: No available formula with the name "cmake@3". Did you mean cmake, cake or make?

@MaxDesiatov MaxDesiatov requested a review from bnbarham July 15, 2025 21:41
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to get this working, but better to not be confusing for now 👍

@MaxDesiatov MaxDesiatov merged commit a47325f into swiftlang:main Jul 17, 2025
3 checks passed
@MaxDesiatov MaxDesiatov deleted the uncmake-brewfile branch July 17, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants