[windows][lldb] fix incorrect LLVM_HOST_TRIPLE when cross-compiling #83061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
@swift-ci please test linux |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the toolchain on an
X86_64machine targetingARM64, which the bots do,LLVM_HOST_TRIPLEwill be set tox86_64-unknown-windows-msvcinstead ofaarch64-pc-windows-msvc.This causes the following crashes related to LLDB not inferring the debugging platform correctly (when cross-compiling, i.e with the bots't builds)
This patch fixes the issue by passing the correct
LLVM_HOST_TRIPLEwhen building.