[Runtimes] Enable overlay builds in macOS smoketest #83071
Merged
+49
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take the chance to match the flags used in the existing build system, and adjust code ownership to cover the file I added to track the experimental flags for the overlays. Addresses rdar://155882420
edymtt
requested review from
etcwilde,
compnerd,
justice-adams-apple,
AnthonyLatsis and
shahmishal
as code owners
|
@swift-ci please smoke test |
compnerd
approved these changes
Jul 15, 2025
AnthonyLatsis
approved these changes
Jul 15, 2025
Fair point -- I did not feel confident factoring this in the early stages of this rewrite, since I noticed we have less flags compared to Core (and possibly the targets in the Supplemental build system may require different ones still, now or in the future). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the chance to match the flags used in the existing build system, and adjust code ownership to cover the file I added to track the experimental flags for the overlays.
Addresses rdar://155882420