[Concurrency] Fix runtime isolated-conformance checks with static stdlib #83086
+58
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
requested review from
ktoso,
etcwilde,
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci test |
ktoso
approved these changes
Jul 16, 2025
Most of linkers pull object files from static archives only if any symbol from that object file is referenced, even if the object contains a ctor code. `Setup.cpp` didn't have any symbols referenced from other code, so it was not linked in when the concurrency runtime was linked in statically. This commit moves the ctor code to `Task.cpp` to ensure that it is always linked in.
kateinoigakukun
force-pushed
the
yt/fix-isolated-conformance-static-link
branch
from
de176b2 to
c0b4727
Compare
|
@swift-ci test |
|
@swift-ci smoke test macOS |
edymtt
approved these changes
Jul 16, 2025
DougGregor
approved these changes
Jul 16, 2025
|
the macOS full-test failure is unrelated, this is fine to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most linkers pull object files from static archives only if any symbol from that object file is referenced, even if the object contains a ctor code.
Setup.cppdidn't have any symbols referenced from other code, so it was not linked in when the concurrency runtime was linked in statically (not WebAssembly-specific). This commit moves the ctor code toTask.cppto ensure that it is always linked in.Close #82825