[6.2][Concurrency] Remove symbols of startSynchronously, make it AEIC #83089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for removal. This spelling of Task.immediate was before SE-review and was NOT accepted and therefore we should try to remove it entirely.
…he method is now AEIC
ktoso
changed the title
ktoso
changed the title
|
@swift-ci please test |
rdar://155596073 Task executors execution may not always hop as expected I'm investigating a fix here as we speak, but disabling the specific piece of the test while we work on it.
|
Included a test disable here from #83095 since that just failed. It is about the task executor interactions which I'm working on to fix properly here: https://github.com/swiftlang/swift/pull/82942/files |
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The
Task.startSynchronouslyAPI was a pre-SwiftEvolution name of this API, and we'd like to remove it eventually. This PR does not remove it, however it does make it AEIC so it does not have ABI, so we could remove it in a future release.Scope/Impact: Users of non-SE-approved Task.startSynchronously which has been renamed due the course of SE as
Task.immediateRisk: Low, the symbol still exists and we verified builds of some existing adopters.
Testing: CI testing, manual verification of adopters if this change would be disruptive or not.
Reviewed by: @xedin
Original PR: #82943
Radar: rdar://155948592