GenericSpecializer: don't pre-specialize C++ reference type for AnyObject #83090
Conversation
eeckstein
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro and
hnrklssn
as code owners
eeckstein
requested review from
aschwaighofer
and removed request for
Xazax-hun,
j-hui,
zoecarver,
hnrklssn,
fahadnayyar and
susmonteiro
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
|
|
||
| @inline(never) | ||
| func go() { | ||
| let x: RefType = RefType.makeRefType() |
There was a problem hiding this comment.
Minor: can we test this in test/Interop/Cxx/foreign-reference/reference-counted.swift? It already has some testing for arrays of foreign reference types (ReferenceCountedTestSuite.test("Global array")).
There was a problem hiding this comment.
As discussed offline, I moved the test to test/Interop/Cxx/foreign-reference
eeckstein
force-pushed
the
fix-pre-specialization
branch
from
d3ad3fa to
40e0360
Compare
|
@swift-ci test |
lib/SILOptimizer/Utils/Generics.cpp
Outdated
| @@ -3163,7 +3163,8 @@ static bool usePrespecialized( | |||
|
|
|||
| if (lowered.isBuiltinBridgeObject() && layout->isBridgeObject()) { | |||
| newSubs.push_back(genericParam->getASTContext().TheBridgeObjectType); | |||
| } else if (lowered.hasRetainablePointerRepresentation()) { | |||
| } else if (lowered.hasRetainablePointerRepresentation() && | |||
There was a problem hiding this comment.
Doesn’t this mean that hasRetainablePointerRepresentation() should be changed? I’m pretty sure other callers also assume AnyObject compatibility when this returns true.
There was a problem hiding this comment.
I'm not sure. hasRetainablePointerRepresentation is used in the type checker but arc for imported c++ classes is mostly about code generation...
There was a problem hiding this comment.
@slavapestov Actually, I agree. It's safer to change hasRetainablePointerRepresentation. I also added a comment.
|
@swift-ci smoke test macos |
…ject Reference counting is not compatible. Fixes a runtime crash if a C++ reference type is put into an Array. swiftlang#83082 rdar://155919841
eeckstein
force-pushed
the
fix-pre-specialization
branch
from
40e0360 to
f962d76
Compare
|
@swift-ci smoke test |
Reference counting is not compatible.
Fixes a runtime crash if a C++ reference type is put into an Array.
#83082
rdar://155919841