wasmswiftsdk.py: build the generator with the freshly built toolchain #83808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Swift CI nodes use Swift 5.9 and Swift 5.10, and as of swiftlang/swift-sdk-generator#227 Swift SDK Generator is no longer tested with Swift 5.9 and 5.10, we should build it with the freshly built toolchain. This will also unblock bump of `swift-tools-version` to 6.0 in the generator's package swiftlang/swift-sdk-generator#237
MaxDesiatov
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
|
@swift-ci smoke test |
|
@swift-ci build toolchain |
MaxDesiatov
added
the
cross-compilation
| swiftc_path = os.path.abspath(self.toolchain.swiftc) | ||
| toolchain_path = os.path.dirname(os.path.dirname(swiftc_path)) | ||
| swift_run = os.path.join(toolchain_path, 'bin', 'swift-run') | ||
| swift_run = os.path.join(self.install_toolchain_path(host_target), "bin", "swift-run") |
There was a problem hiding this comment.
Doesn't it break builds with --native-swift-tools-path and skip-build-swift?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Swift CI nodes use Swift 5.9 and Swift 5.10, and as of swiftlang/swift-sdk-generator#227 Swift SDK Generator is no longer tested with Swift 5.9 and 5.10, we should build it with the freshly built toolchain. This will also unblock bump of
swift-tools-versionto 6.0 in the generator's package swiftlang/swift-sdk-generator#237.