Skip to content

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Sep 22, 2025

Explanation: #82616 added a new exposure kind for the @_expose attribute, but did not update the serialization format to account for the new kind. This caused a crash when serializing a module that used @_expose(wasm).
Issues: #84196 #84140
Original PRs: #84215
Risk: Low, it only affects when using @_expose(wasm)
Testing: Added a test.
Reviewers: @bnbarham, @MaxDesiatov

swiftlang#82616 added a new exposure kind
for the `@_expose` attribute, but did not update the serialization
format to account for the new kind. This caused a crash when
serializing a module that used `@_expose(wasm)`.
@kateinoigakukun kateinoigakukun marked this pull request as ready for review September 22, 2025 14:20
@kateinoigakukun kateinoigakukun requested a review from a team as a code owner September 22, 2025 14:20
@kateinoigakukun
Copy link
Member Author

@swift-ci test

@kateinoigakukun kateinoigakukun added the 🍒 release cherry pick Flag: Release branch cherry picks label Sep 22, 2025
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference - #82616 was cherry-picked in #84053.

This needs a module format version bump doesn't it? CC @xymus

@xymus
Copy link
Contributor

xymus commented Sep 22, 2025

Right, it changes the format so it would need a version bump. Please bump up the value of SWIFTMODULE_VERSION_MINOR and note the related change in the comment.

@kateinoigakukun
Copy link
Member Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

4 similar comments
@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@MaxDesiatov
Copy link
Contributor

@xymus @bnbarham CI is fully green now, ready for re-review

@kateinoigakukun kateinoigakukun merged commit 32846ed into swiftlang:release/6.2 Sep 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants