-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[6.2][wasm] Fix @_expose(wasm)
serialization crash
#84434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.2][wasm] Fix @_expose(wasm)
serialization crash
#84434
Conversation
swiftlang#82616 added a new exposure kind for the `@_expose` attribute, but did not update the serialization format to account for the new kind. This caused a crash when serializing a module that used `@_expose(wasm)`.
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it changes the format so it would need a version bump. Please bump up the value of |
@swift-ci test |
@swift-ci test windows |
4 similar comments
@swift-ci test windows |
@swift-ci test windows |
@swift-ci test windows |
@swift-ci test windows |
Explanation: #82616 added a new exposure kind for the
@_expose
attribute, but did not update the serialization format to account for the new kind. This caused a crash when serializing a module that used@_expose(wasm)
.Issues: #84196 #84140
Original PRs: #84215
Risk: Low, it only affects when using
@_expose(wasm)
Testing: Added a test.
Reviewers: @bnbarham, @MaxDesiatov