Create a special Xcode selector for macOS #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a little documentation for the xcode toolchain selector Add tests for the xcode toolchain selector and version
|
@swift-ci test macOS |
cmcgee1024
changed the title
cmcgee1024
requested review from
shahmishal,
justice-adams-apple and
etcwilde
as code owners
etcwilde
approved these changes
Jul 29, 2025
| @@ -49,8 +49,14 @@ public struct Config: Codable, Equatable, Sendable { | |||
| } | |||
|
|
|||
| public func listInstalledToolchains(selector: ToolchainSelector?) -> [ToolchainVersion] { | |||
| #if os(macOS) | |||
| let systemToolchains: [ToolchainVersion] = [.xcodeVersion] | |||
There was a problem hiding this comment.
Is Xcode guaranteed to be installed where swiftly is installed? Should we query to ensure that there is a toolchain installed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the feature of a special selector "xcode" that can be used like the other swiftly
selectors for some operations, such as
swiftly use, andswiftly list, but has noreal effect on other operations.
With this feature, you can
swiftly use xcodeand then when you run the proxies foritems like swift, clang, and other common toolchain binaries they will be run on the
Xcode toolchain.
When xcode is selected then
swiftly runwill run with the currently selected xcodetoolchain (or command-line tools) reported by
xcrun -fas the toolchain on the path.When you run
swiftly listthere is a special entry for "xcode" that is decorated in asimilar way to indicate whether it is the (global) default, and/or in-use toolchain as a
result of the selection mechanism.