Break immediately when cancelling a multiple test run #1589
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using "Run Test Multiple Times" or "Run Until Failure" cancelling the run would prevent subsequent test runs from occuring, but the logs would still print out "Beginning Test Iteration #x" for each remaining test iteration. Exit out of the loop that is running the tests multiple times once cancellation has been requested. Also clean up the cancellation error message in the logs to be formatted not as an error but just a message.
matthewbastien
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using "Run Test Multiple Times" or "Run Until Failure" cancelling the run would prevent subsequent test runs from occuring, but the logs would still print out "Beginning Test Iteration #x" for each remaining test iteration.
Exit out of the loop that is running the tests multiple times once cancellation has been requested. Also clean up the cancellation error message in the logs to be formatted not as an error but just a message.