[Platform] Add event system for string input conversion #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamyHakam
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
added
Bug
chr-hertel
added
the
Hackathon 2025
chr-hertel
force-pushed
the
feature/platform-input-event-system
branch
from
5a3dcaf to
e852ce8
Compare
chr-hertel
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Took me a while to come back to you, but took care of rebase and style changes we had.
Thanks @RamyHakam!
chr-hertel
force-pushed
the
feature/platform-input-event-system
branch
from
e852ce8 to
0f277e6
Compare
chr-hertel
force-pushed
the
feature/platform-input-event-system
branch
from
0f277e6 to
c5e362d
Compare
|
It took time, but here we go, this is in now. Thank you very much @RamyHakam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements event-based input processing to resolve fatal errors when string payloads are passed to ModelClient implementations using
array_merge($payload, $options).Solution:
PlatformInvokationEvent: Dispatched before platform invocationStringToMessageBagListener: Converts strings to MessageBag for models with INPUT_MESSAGES capability$platform->invoke($model, 'Hello')Backward Compatible: EventDispatcher is optional, existing code unchanged.