[MCP Bundle] Fix dependency injection and standardize invokable pat… #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes critical issues preventing MCP tools with constructor
dependencies from working and aligns the codebase with the official MCP SDK.
Changes:
- Fix McpPass to use Reference objects for ServiceLocator registration
Previously passed tag arrays directly, causing crashes when tools had
constructor dependencies
- Fix services.php to use Server::make() instead of Server::builder()
The official mcp/sdk uses Server::make() returning ServerBuilder,
not Builder class with builder() method
- Migrate all demo MCP capabilities to invokable pattern
The Bundle's registerAttributeForAutoconfiguration() only detects
class-level attributes, not method-level. Changed to:
* Tool: #[McpTool] on class + __invoke() method
* Prompt: #[McpPrompt] on class + __invoke() method
* Resource: #[McpResource] on class + __invoke() method
* ResourceTemplate: #[McpResourceTemplate] on class + __invoke() method
- Add LoggerInterface to CurrentTimeTool to demonstrate DI works
- Update documentation examples to show invokable pattern
- Improve McpPassTest to verify ServiceLocator uses References
Previous tests only checked presence, not type of values
camilleislasse
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MCP Bundle] Fix dependency injection and standardize invokable pattern
This commit fixes critical issues preventing MCP tools with constructor
dependencies from working and aligns the codebase with the official MCP SDK.
Changes:
Fix McpPass to use Reference objects for ServiceLocator registration Previously passed tag arrays directly, causing crashes when tools had constructor dependencies
Fix services.php to use Server::make() instead of Server::builder() The official mcp/sdk uses Server::make() returning ServerBuilder, not Builder class with builder() method
Migrate all demo MCP capabilities to invokable pattern The Bundle's registerAttributeForAutoconfiguration() only detects class-level attributes, not method-level. Changed to:
Add LoggerInterface to CurrentTimeTool to demonstrate DI works
Update documentation examples to show invokable pattern
Improve McpPassTest to verify ServiceLocator uses References Previous tests only checked presence, not type of values