-
-
Notifications
You must be signed in to change notification settings - Fork 103
[Demo] Fix demo by PHPStan findings + pipeline #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c0e1148
to
e3dd224
Compare
@OskarStark need your help here with the conditional return on the vectorizer - breaks my head or maybe just too late this code: ai/demo/src/Blog/Command/QueryCommand.php Lines 44 to 52 in a4747cb
with this return: ai/src/store/src/Document/VectorizerInterface.php Lines 29 to 37 in a4747cb
leads to:
|
e3dd224
to
9757a65
Compare
Used Follow up with #768 |
Turns out pipeline was not running phpstan on the demo - this PR adds that and fixes the open issues.