Skip to content

[Agent] Enable tools to add sources #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

[Agent] Enable tools to add sources #764

merged 1 commit into from
Oct 9, 2025
+403 −4

Conversation

chr-hertel
Copy link
Member

@chr-hertel chr-hertel commented Oct 9, 2025 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues
License MIT
image
  • tests
  • provide way without keep messages

@chr-hertel chr-hertel added the Agent Issues & PRs about the AI Agent component label Oct 9, 2025
@chr-hertel chr-hertel force-pushed the tool-sources branch 2 times, most recently from bc54a17 to 6b1e54b Compare October 9, 2025 01:48
OskarStark
OskarStark reviewed Oct 9, 2025
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests , but looks good 🙃

@chr-hertel
Copy link
Member Author

not yet happy how sources are transported to the surface.
i like the slim API on tool level, but the other side is not that great with keepToolMessages and double-foreach

thinking of shifting the addition of AssistantMessage to the MessageBag into the Agent instead of user land code

@chr-hertel chr-hertel force-pushed the tool-sources branch 3 times, most recently from f989000 to c743cea Compare October 9, 2025 20:25
OskarStark
OskarStark reviewed Oct 9, 2025
View reviewed changes
@chr-hertel chr-hertel force-pushed the tool-sources branch 5 times, most recently from 92bd11b to 33f620f Compare October 9, 2025 21:26
@chr-hertel chr-hertel marked this pull request as ready for review October 9, 2025 21:26
@chr-hertel chr-hertel requested a review from Nyholm as a code owner October 9, 2025 21:26
@chr-hertel chr-hertel requested a review from OskarStark October 9, 2025 21:27
@OskarStark
Copy link
Contributor

Thank you Christopher.

@OskarStark OskarStark merged commit dec5436 into symfony:main Oct 9, 2025
16 checks passed
@chr-hertel chr-hertel deleted the tool-sources branch October 9, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner

Assignees
No one assigned
Labels
Agent Issues & PRs about the AI Agent component Feature New feature Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chr-hertel @OskarStark @carsonbot