-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add End to End tests on GitHub CI #1584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the indentation use 4 spaces?
|
||
- name: Install Symfony CLI | ||
run: | | ||
wget https://get.symfony.com/cli/installer -O - | bash | ||
echo "$HOME/.symfony*/bin" >> $GITHUB_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Install Symfony CLI | |
run: | | |
wget https://get.symfony.com/cli/installer -O - | bash | |
echo "$HOME/.symfony*/bin" >> $GITHUB_PATH | |
tools: symfony |
uses: shivammathur/setup-php@v2 | ||
with: | ||
php-version: '8.4' | ||
extensions: mbstring, xml, ctype, iconv, intl, pdo_sqlite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intention to have only these extensions installed? Then 'none' should be added:
extensions: mbstring, xml, ctype, iconv, intl, pdo_sqlite | |
extensions: none, ctype, iconv, intl, mbstring, pdo_sqlite, xml |
- name: Test application | ||
working-directory: ./symfony_cli_test | ||
run: | | ||
php bin/console --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
php bin/console --version | |
php bin/console about |
run: | | ||
working-directory: ./composer_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run: | | |
working-directory: ./composer_test | |
working-directory: ./composer_test | |
run: | |
To avoid issues in the future, I propose to add a daily test that checks that this application is installable and works using different methods: Symfony CLI, Composer and Git clone.