Add End to End tests on GitHub CI #1584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosier
suggested changes
Jul 23, 2025
Comment on lines
22
to
26
|
|
||
| - name: Install Symfony CLI | ||
| run: | | ||
| wget https://get.symfony.com/cli/installer -O - | bash | ||
| echo "$HOME/.symfony*/bin" >> $GITHUB_PATH |
There was a problem hiding this comment.
Suggested change
| - name: Install Symfony CLI | |
| run: | | |
| wget https://get.symfony.com/cli/installer -O - | bash | |
| echo "$HOME/.symfony*/bin" >> $GITHUB_PATH | |
| tools: symfony |
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '8.4' | ||
| extensions: mbstring, xml, ctype, iconv, intl, pdo_sqlite |
There was a problem hiding this comment.
Is the intention to have only these extensions installed? Then 'none' should be added:
Suggested change
| extensions: mbstring, xml, ctype, iconv, intl, pdo_sqlite | |
| extensions: none, ctype, iconv, intl, mbstring, pdo_sqlite, xml |
| - name: Test application | ||
| working-directory: ./symfony_cli_test | ||
| run: | | ||
| php bin/console --version |
There was a problem hiding this comment.
Suggested change
| php bin/console --version | |
| php bin/console about |
Comment on lines
57
to
58
| run: | | ||
| working-directory: ./composer_test |
There was a problem hiding this comment.
Suggested change
| run: | | |
| working-directory: ./composer_test | |
| working-directory: ./composer_test | |
| run: | |
There was a problem hiding this comment.
I think you missed this one
There was a problem hiding this comment.
You are right. Sorry. Fixed! Thanks.
|
Jan, thanks for the review! I added all your fixes. |
rosier
suggested changes
Jul 25, 2025
Comment on lines
4
to
6
| schedule: | ||
| # run daily at 2:00 AM UTC | ||
| - cron: '0 2 * * *' |
There was a problem hiding this comment.
Suggested change
| schedule: | |
| # run daily at 2:00 AM UTC | |
| - cron: '0 2 * * *' | |
| schedule: | |
| # run daily at 2:00 AM UTC | |
| - cron: '0 2 * * *' | |
Comment on lines
97
to
119
| script: | | ||
| const title = `End to End Test Failed - ${new Date().toISOString().split('T')[0]}`; | ||
| const body = ` | ||
| The daily end to end test workflow has failed. This means users may be experiencing issues installing the Symfony Demo application. | ||
|
|
||
| **Failed Jobs:** | ||
| - Check the workflow run for details: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} | ||
|
|
||
| **Installation Methods Tested:** | ||
| - Symfony CLI installation | ||
| - Composer create-project | ||
| - Git clone + composer install | ||
|
|
||
| Please investigate and fix the installation issues as soon as possible. | ||
| `; | ||
|
|
||
| github.rest.issues.create({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| title: title, | ||
| body: body, | ||
| labels: ['bug'] | ||
| }); |
There was a problem hiding this comment.
Suggested change
| script: | | |
| const title = `End to End Test Failed - ${new Date().toISOString().split('T')[0]}`; | |
| const body = ` | |
| The daily end to end test workflow has failed. This means users may be experiencing issues installing the Symfony Demo application. | |
| **Failed Jobs:** | |
| - Check the workflow run for details: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} | |
| **Installation Methods Tested:** | |
| - Symfony CLI installation | |
| - Composer create-project | |
| - Git clone + composer install | |
| Please investigate and fix the installation issues as soon as possible. | |
| `; | |
| github.rest.issues.create({ | |
| owner: context.repo.owner, | |
| repo: context.repo.repo, | |
| title: title, | |
| body: body, | |
| labels: ['bug'] | |
| }); | |
| script: | | |
| const title = `End to End Test Failed - ${new Date().toISOString().split('T')[0]}`; | |
| const body = ` | |
| The daily end to end test workflow has failed. This means users may be experiencing issues installing the Symfony Demo application. | |
| **Failed Jobs:** | |
| - Check the workflow run for details: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} | |
| **Installation Methods Tested:** | |
| - Symfony CLI installation | |
| - Composer create-project | |
| - Git clone + composer install | |
| Please investigate and fix the installation issues as soon as possible. | |
| `; | |
| github.rest.issues.create({ | |
| owner: context.repo.owner, | |
| repo: context.repo.repo, | |
| title: title, | |
| body: body, | |
| labels: ['bug'] | |
| }); |
javiereguiluz
force-pushed
the
end_to_end_test
branch
from
f0f3886 to
2706f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid issues in the future, I propose to add a daily test that checks that this application is installable and works using different methods: Symfony CLI, Composer and Git clone.