Skip to content

Add End to End tests on GitHub CI #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

javiereguiluz
Copy link
Member

To avoid issues in the future, I propose to add a daily test that checks that this application is installable and works using different methods: Symfony CLI, Composer and Git clone.

Copy link
Contributor

@rosier rosier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the indentation use 4 spaces?

Comment on lines +22 to +26

- name: Install Symfony CLI
run: |
wget https://get.symfony.com/cli/installer -O - | bash
echo "$HOME/.symfony*/bin" >> $GITHUB_PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install Symfony CLI
run: |
wget https://get.symfony.com/cli/installer -O - | bash
echo "$HOME/.symfony*/bin" >> $GITHUB_PATH
tools: symfony

uses: shivammathur/setup-php@v2
with:
php-version: '8.4'
extensions: mbstring, xml, ctype, iconv, intl, pdo_sqlite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention to have only these extensions installed? Then 'none' should be added:

Suggested change
extensions: mbstring, xml, ctype, iconv, intl, pdo_sqlite
extensions: none, ctype, iconv, intl, mbstring, pdo_sqlite, xml

- name: Test application
working-directory: ./symfony_cli_test
run: |
php bin/console --version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
php bin/console --version
php bin/console about

Comment on lines +57 to +58
run: |
working-directory: ./composer_test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: |
working-directory: ./composer_test
working-directory: ./composer_test
run: |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants