Add support for Symfony 8 #678
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
symfony-8-support
branch
from
2f9393d to
d6646c1
Compare
Member
Author
|
The CI was already red before this PR btw |
dunglas
force-pushed
the
symfony-8-support
branch
from
d6646c1 to
b00e50c
Compare
Member
Kocal
force-pushed
the
symfony-8-support
branch
from
b00e50c to
9ef85eb
Compare
Kocal
commented
Nov 22, 2025
| } | ||
|
|
||
| protected function doRequest($request) | ||
| protected function doRequest(object $request): void |
Member
Author
There was a problem hiding this comment.
Member
Author
|
@dunglas PR rebased, I also fixed |
xabbuh
reviewed
Nov 22, 2025
| "symfony/http-kernel": "^6.4 || ^7.3 || ^8.0", | ||
| "symfony/process": "^6.4 || ^7.3 || ^8.0" | ||
| "symfony/dom-crawler": "^6.4 || ^7.3 || ^8.0 || ^8.0", | ||
| "symfony/http-client": "^6.4 || ^7.0 || ^8.0", |
Member
There was a problem hiding this comment.
This is the only needed change in this file.
xabbuh
reviewed
Nov 22, 2025
| */ | ||
| class ChoiceFormFieldTest extends TestCase | ||
| { | ||
| #[DataProvider('clientFactoryProvider')] |
Member
There was a problem hiding this comment.
If the goal is to be compatible with PHPUnit 11+, we should also add a job using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIRC the CI was already broken before this PR