-
-
Notifications
You must be signed in to change notification settings - Fork 368
[Icons] Add support for <title> and <desc> elements in SVG for accessibility #2904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xDeSwa
wants to merge
7
commits into
symfony:2.x
Choose a base branch
from
xDeSwa:title-desc-feature
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+129
−2
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b9f41c9
Add support for <title> and <desc> elements in SVG for accessibility
xDeSwa 423937e
Add support for <title> and <desc> elements in SVG for accessibility
xDeSwa 317f732
Update for suggestions
xDeSwa 8b8296d
Update index.rst
xDeSwa 27d316b
Update Icon.php
xDeSwa 3dead42
Merge branch 'symfony:2.x' into title-desc-feature
xDeSwa 59703cf
Add title/desc accessibility support and related tests
xDeSwa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
<?php | ||
|
||
namespace Symfony\UX\Icons\Tests\Unit; | ||
|
||
use PHPUnit\Framework\TestCase; | ||
use Symfony\UX\Icons\Icon; | ||
|
||
class IconAccessibilityTest extends TestCase | ||
{ | ||
public function testTitleIsIncludedInOutput() | ||
{ | ||
$icon = new Icon('<path d="M0 0h24v24H0z" fill="none"/>', ['title' => 'Test Icon']); | ||
$html = $icon->toHtml(); | ||
$this->assertMatchesRegularExpression('/<title( id="[^"]*")?>Test Icon<\/title>/', $html); | ||
} | ||
|
||
public function testDescIsIncludedInOutput() | ||
{ | ||
$icon = new Icon('<circle cx="12" cy="12" r="10"/>', ['desc' => 'This is a test circle']); | ||
$html = $icon->toHtml(); | ||
$this->assertMatchesRegularExpression('/<desc( id="[^"]*")?>This is a test circle<\/desc>/', $html); | ||
} | ||
|
||
public function testTitleAndDescWithCustomAriaLabelledBy() | ||
{ | ||
$attributes = [ | ||
'title' => 'My Line', | ||
'desc' => 'This is a diagonal line', | ||
'aria-labelledby' => 'custom-id', | ||
]; | ||
$icon = new Icon('<line x1="0" y1="0" x2="10" y2="10"/>', $attributes); | ||
|
||
$html = $icon->toHtml(); | ||
$this->assertStringContainsString('<title>My Line</title>', $html); | ||
$this->assertStringContainsString('<desc>This is a diagonal line</desc>', $html); | ||
$this->assertStringContainsString('aria-labelledby="custom-id"', $html); | ||
} | ||
|
||
public function testToStringReturnsHtml() | ||
{ | ||
$icon = new Icon('<path d="M0 0h24v24H0z"/>'); | ||
$this->assertSame($icon->toHtml(), (string) $icon); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
id
attributes do no match the actual behaviour