-
-
Notifications
You must be signed in to change notification settings - Fork 370
[Autocomplete] Allow plugins to be disabled through tom_select_options.plugins.<plugin> = false
#401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach - just one comment
@weaverryan Bit off topic but related to solving your feedback: Where can I find information about how to run tests cases etc. I think I am missing a good contribute to symfony/ux page. The part in the readme is very short and is also missing a part about building... |
@maartendekeizer that's fair - that could certainly use some help :). To run tests for a specific component, from the root of the project
Let me know if that gives you any trouble - the tests can be tricky, but the existing ones in autocomplete should be fairly similar to what you're trying to do. |
Friendly ping @maartendekeizer :) |
Hey @maartendekeizer is there anything I can help with? 😄 |
@weaverryan How should we proceed with this PR? |
+1 for a solution for this problem. I'm facing it too and would like to have the PR procceded. |
I would vote for merging it to the next release please. We really need the fix. |
As the PR seems mergable without conflict, when can we expect this fix to be released? |
Working on it |
tom_select_options.plugins.<plugin> = false
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
I've pushed a new commit that allows default plugins to be disableable when passing <?php
#[AsEntityAutocompleteField]
class IngredientAutocompleteType extends AbstractType
{
public function configureOptions(OptionsResolver $resolver): void
{
$resolver->setDefaults([
'class' => Ingredient::class,
'tom_select_options' => [
'plugins' => [
'clear_button' => false, // Disable the clear button
'remove_button' => false, // Disable the remove button
],
],
]);
}
public function getParent(): string
{
return BaseEntityAutocompleteType::class;
}
} I added some tests too |
…ns.plugins.<plugin> = false`
Thank you @maartendekeizer. |
When plugins option is defined Symfony UX will no longer add some plugins by default. This make it possible to render a autocomplete without clear button extensions for example.