fix: make VSCode PID optional in MCP server #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MCP server now gracefully handles cases where VSCode PID discovery fails. This enables the server to work with persistent agents and other scenarios where it's not running from a VSCode terminal. Changes: - Made shell_pid Option<u32> throughout the codebase - Updated DispatchHandle::new to accept Option<u32> - Updated IPCCommunicator to store Option<u32> for terminal_shell_pid - Server::new now logs a warning instead of bailing when PID discovery fails - PoloMessage payload is now empty (shell_pid goes in MessageSender) - Updated send_polo and send_goodbye to not take shell_pid parameter - Fixed test to use Some(12345) for shell_pid The TypeScript and Swift codebases already had shell_pid as optional, so no changes were needed there. Co-authored-by: Claude <claude@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MCP server now gracefully handles cases where VSCode PID discovery fails. This enables the server to work with persistent agents and other scenarios where it's not running from a VSCode terminal.
Changes:
The TypeScript and Swift codebases already had shell_pid as optional, so no changes were needed there.