Fix UI lag during taskspace deletion by making operations async #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made deleteTaskspace function async to prevent blocking main thread - Wrapped git operations (worktree removal, branch deletion) in background task - Updated UI calls to use MainActor for thread-safe state updates - Prevents app hanging during delete operations Co-authored-by: Claude <claude@anthropic.com>
- Added executeProcessAsync() that runs git commands in detached tasks - Replaced synchronous executeProcess calls in deleteTaskspace - Now waitUntilExit() runs off main thread completely - Further improves UI responsiveness during delete operations Co-authored-by: Claude <claude@anthropic.com>
- Replaced computed branchInfo property with cached state - Load branch info asynchronously on dialog appear - Prevents multiple git commands on every UI refresh - Eliminates lag when clicking delete branch checkbox Co-authored-by: Claude <claude@anthropic.com>
aaronjeline
force-pushed
the
fix/ui-delete-performance
branch
from
7f8c361 to
fe291f9
Compare
Contributor
Author
|
I've added a cache for the git info, but it's only while the dialog is live, not the entire application window. |
- Shows progress spinner and 'Checking branch status...' text - Improves UX by indicating async operation in progress - Hides loading state once branch info is cached Co-authored-by: Claude <claude@anthropic.com>
aaronjeline
force-pushed
the
fix/ui-delete-performance
branch
from
fe291f9 to
41cb416
Compare
nikomatsakis
approved these changes
Oct 5, 2025
Member
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
This looks good! I had noticed that UI is very slow but hadn't read carefully into it.
| }.value | ||
|
|
||
| // Set default deleteBranch toggle based on safety analysis | ||
| deleteBranch = (cachedBranchInfo.unmergedCommits == 0 && !cachedBranchInfo.hasUncommittedChanges) |
Member
There was a problem hiding this comment.
I guess what happens is that, initially, the cached branch name is empty, so the user sees no checkbox at all, but then it appears some time later once the git command has completed? I think it'd be nice if we displayed a message like "...determining github branch information..." to keep them up-to-date.
| .multilineTextAlignment(.center) | ||
|
|
||
| if !cachedBranchInfo.branchName.isEmpty { | ||
| if isLoadingBranchInfo { |
Member
There was a problem hiding this comment.
...lol, I guess you anticipated my request...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting taskspaces caused main UI thread to hang. This makes a bunch of stuff in that flow async, preventing this issue.