Fix bypass permissions + dependency upgrades #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bypass permission setting was being stored using the agent's display name (e.g., 'Claude Code') instead of the agent ID (e.g., 'zed-claude-code'). This caused the setting to never be found when checking permissions, so clicking 'Bypass Permissions' had no effect. Additionally, if the agent had no existing settings entry, we would skip saving entirely. Now we create the entry if it doesn't exist. Changes: - Pass both agentId and agentName through the approval flow - Use agentId for settings lookup (agents object is keyed by ID) - Create agent settings entry if it doesn't exist - Keep agentName for display/logging purposes Co-authored-by: Claude <[email protected]>
Instead of storing bypassPermissions as a property on each agent entry in symposium.agents, use a dedicated symposium.bypassPermissions array of agent IDs. This: - Avoids polluting agent configuration with runtime preferences - Prevents needing to create settings entries for built-in agents - Separates 'how to spawn' from 'how to interact with' an agent - Fixes confusion where display-name-keyed entries caused duplicates Co-authored-by: Claude <[email protected]>
Updates ElizaAgent::new() call with new deterministic parameter (false). Co-authored-by: Claude <[email protected]>
- sacp: 10.0.0 -> 10.1.0 - sacp-tokio: 10.0.0 -> 10.1.0 - sacp-conductor: 10.0.0 -> 10.0.1 - sacp-rmcp: 10.0.0 -> 10.0.1 - sacp-tee: 10.0.0 -> 10.0.1 - yopo: 10.0.0 -> 10.0.1 Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains a bug fix for the VSCode extension and dependency upgrades.
Bug Fix: Bypass Permissions
Fixed the "bypass permissions" feature in the VSCode extension which was not working due to two issues:
Wrong key for settings lookup - The code was using the agent's display name (e.g., "Claude Code") instead of the agentId (e.g., "zed-claude-code") when storing/retrieving bypass permission settings.
Missing entry creation - The code assumed the agent already had a settings entry. If it didn't exist, the conditional check failed silently and the setting was never saved.
Both the main approval handler and the test helper now correctly use agentId and create the settings entry if needed.
Dependency Upgrades
Updated to latest versions:
elizacp: 10.0.0 → 11.0.0 (includes API change:ElizaAgent::new()now takes adeterministic: boolparameter)sacp: 10.0.0 → 10.1.0sacp-tokio: 10.0.0 → 10.1.0sacp-conductor: 10.0.0 → 10.0.1sacp-rmcp: 10.0.0 → 10.0.1sacp-tee: 10.0.0 → 10.0.1yopo: 10.0.0 → 10.0.1Also removed unused
sacp-testworkspace dependency.