Error as array #18
Open
Error as array #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spruce-bruce
requested changes
Apr 11, 2018
Contributor
spruce-bruce
left a comment
spruce-bruce
left a comment
There was a problem hiding this comment.
One change - and please add scott as a reviewer also
src/DropNCrop.js
Outdated
| className="dropzone-validation" | ||
| > | ||
| {value && value.error} | ||
| <p>{value && value.error[0]}</p> |
Contributor
There was a problem hiding this comment.
When displaying multiple error messages like this it's more flexible to just loop through all the errors and output them.
{value && value.error && value.error.map(error => <p>{error}</p>}
Also we should have scott review this to make sure he's cool with multiple errors being displayed inside p tags here.
There was a problem hiding this comment.
I think I'm okay with this? Would love to see what it looks like all validated out. @dmmcinty send me a screenshot ??
scottianstewart
previously approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handling a TODO and updating the documentation