Delete .github/workflows/triage.yml #308
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the GitHub Actions triage workflow that previously automated issue and pull request management. The workflow handled automatic labeling based on title/body content, assigned issues to a specific user (PaulAndersonS), added automated comments, and managed stale issues/PRs. After this deletion, the .github/workflows directory will no longer exist in the repository, meaning all automated triage functionality will be removed.
Key Changes:
- Complete removal of the automated triage workflow for issues and pull requests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CONTRIBUTING.md
Outdated
| We are in the early stages of building the Syncfusion Toolkit for .NET MAUI, and we're excited for you to join us during this journey! | ||
|
|
||
| Please refer to our [Development Guide](DEVELOPMENT.md) for instructions on setting up your development environment. | ||
| Please refer to our [Development Guide](DEVELOPMENT.md) for instructions on setting up your development environment. |
There was a problem hiding this comment.
Trailing whitespace has been added to this line. This is typically considered a code quality issue and should be removed. Most editors and linters flag trailing whitespace as it can cause unnecessary diff noise in version control.
.github/CONTRIBUTING.md
Outdated
| Thank you for your interest in contributing to the Syncfusion Toolkit for .NET MAUI! In this document, we'll outline what you need to know about contributing and how to get started. | ||
|
|
||
| First and foremost: if you are thinking about contributing a bigger change or feature, **please open an issue or talk to a core team member first**! By doing this, we can coordinate and see if the change you are going to work on is something that aligns with our current priorities and is something we can commit to reviewing and merging within a reasonable time. We would want to prevent you from investing a lot of your valuable time in something that might not be in line with what we want for the toolkit. | ||
| First and foremost: if you are thinking about contributing a bigger change or feature, **please open an issue or talk to a core team member first**! By doing this, we can coordinate and see if the change you are going to work on is something that aligns with our current priorities and is something we can commit to reviewing and merging within a reasonable time. We would want to prevent you from investing a lot of your valuable time in something that might not be in line with what we want for the toolkit. |
There was a problem hiding this comment.
Trailing whitespace has been added to this line. This is typically considered a code quality issue and should be removed. Most editors and linters flag trailing whitespace as it can cause unnecessary diff noise in version control.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v3 | ||
| with: | ||
| languages: 'csharp' |
There was a problem hiding this comment.
This file appears to be an incomplete GitHub Actions workflow. It only contains a single step definition without the required workflow structure. A valid GitHub Actions workflow needs:
- A
namefield at the top level - Trigger conditions (
on:field) - A
jobssection containing one or more jobs - Each job needs a
runs-onfield and astepssection
Currently, this file only has step content (lines 1-4), which will cause the workflow to fail. This should either be a complete workflow file or be removed if it's meant to be integrated elsewhere.
| - name: Initialize CodeQL | |
| uses: github/codeql-action/init@v3 | |
| with: | |
| languages: 'csharp' | |
| name: CodeQL | |
| on: | |
| push: | |
| pull_request: | |
| jobs: | |
| analyze: | |
| runs-on: ubuntu-latest | |
| permissions: | |
| security-events: write | |
| steps: | |
| - name: Checkout repository | |
| uses: actions/checkout@v4 | |
| - name: Initialize CodeQL | |
| uses: github/codeql-action/init@v3 | |
| with: | |
| languages: 'csharp' | |
| - name: Autobuild | |
| uses: github/codeql-action/autobuild@v3 | |
| - name: Perform CodeQL Analysis | |
| uses: github/codeql-action/analyze@v3 |
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v3 | ||
| with: | ||
| languages: 'csharp' |
There was a problem hiding this comment.
The PR title and description indicate this PR is about deleting the triage workflow, but the changes also include adding a new (incomplete) CodeQL workflow file and modifying the CONTRIBUTING.md file with a trailing whitespace. These additional changes are not mentioned in the PR description. Consider either:
- Updating the PR description to explain why the CodeQL workflow is being added and why CONTRIBUTING.md is being modified
- Splitting these changes into separate PRs for better clarity and reviewability
This is especially important since the new CodeQL workflow has critical syntax issues that need to be addressed.
Root Cause of the Issue
Description of Change
Issues Fixed
Fixes #
Screenshots
Before:
After: