-
Notifications
You must be signed in to change notification settings - Fork 568
fix(autostart): remove --no-console from Windows instructions (fixes #945) #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(autostart): remove --no-console from Windows instructions (fixes #945) #955
Conversation
Screenshots have been added. |
I'm with a Win11 installation up and running. I can continue the screenshots and Task Scheduler-related changes in #926. |
@tomasz1986 i've made some image adjustments on rafaeloledo@97e8b97 i think you have access to it, since it's a fork Summary
|
Thanks for the screenshots, I think in this specific PR including the ones that have |
You can just add a co-authored-by when merging. |
This is sufficient. |
11da5ae
to
1d1c4f4
Compare
With the advent of Windows Terminal and it being the default shell both in newer releases of Windows 10, and in Windows 11, the `--no-console` command line switch no longer works. For this reason, remove it from the commands listed in the autostart instructions. When it comes to the Task Scheduler part, it has never actually been needed anyway, and in the Startup folder instructions, it can be worked around by using the native `conhost.exe --headless` method. Signed-off-by: Tomasz Wilczyński <[email protected]> Co-authored-by: Rafael Ledo <[email protected]> Signed-off-by: Tomasz Wilczyński <[email protected]>
1d1c4f4
to
414244e
Compare
The images that not get merged are out of scope of this PR, right? Sorry for that. 🤗 |
fix(autostart): remove --no-console from Windows instructions
With the advent of Windows Terminal and it being the default shell both
in newer releases of Windows 10, and in Windows 11, the
--no-console
command line switch no longer works. For this reason, remove it from the
commands listed in the autostart instructions. When it comes to the Task
Scheduler part, it has never actually been needed anyway, and in the
Startup folder instructions, it can be worked around by using the native
conhost.exe --headless
method.Signed-off-by: Tomasz Wilczyński [email protected]
Co-authored-by: Rafael Ledo [email protected]