[IMP Port] Visitor Specific Species by honeyed-lemons · Pull Request #1 · syndicate-ss14/macrocosm

honeyed-lemons · 2026-03-13T23:54:48Z

About the PR

Port of impstation/imp-station-14#3522.
Allows species to be declared non-roundstart and still be randomly generated for vistor shuttles and random ghostroles and such

Why / Balance

Well, you see, Macrocosm is going to have species that are non roundstart yet still want to be playable in game via ghost roles. This is good i think.

Technical details

Added two new datafields to the species component and modified the Random function in HumanoidCharacterProfile fairly extensively.

Media

Does.. not really need media? I can guarantee this is tested, however.

Requirements

I have read and am following the Pull Request and Changelog Guidelines.
I have added media to this PR or it does not require an in-game showcase.

Breaking changes

N/A

Changelog

🆑

tweak: Visitors can now be non-roundstart species.

…522) * Allow non-roundstart species to roll midround * Allow non-roundstart species to roll midround * oops forgot some comments * i forgot * Reimplement blacklist. i hate expression lambdas. * randomChance * add ungu (cherry picked from commit 046df23e45e19e59f453fe0f4d8aba4d85c046fe)

Content.Shared/Preferences/HumanoidCharacterProfile.cs

Resources/Prototypes/Species/vox.yml

changes made

mqole · 2026-03-16T00:24:51Z

Content.Server/Humanoid/Systems/RandomHumanoidSystem.cs

            throw new ArgumentException("Could not get random humanoid settings");

-        var profile = HumanoidCharacterProfile.Random(prototype.SpeciesBlacklist);
+        var profile = HumanoidCharacterProfile.Random(prototype.SpeciesBlacklist, false); // MACRO


Suggested change

var profile = HumanoidCharacterProfile.Random(prototype.SpeciesBlacklist, false); // MACRO

var profile = HumanoidCharacterProfile.Random(prototype.SpeciesBlacklist, false); // MACRO, added false

mqole · 2026-03-16T00:26:47Z

Content.Shared/Preferences/HumanoidCharacterProfile.cs


        // TODO: This should eventually not be a visual change only.
-        public static HumanoidCharacterProfile Random(HashSet<string>? ignoredSpecies = null)
+        // MACRO start, extensive changes.


move to line 224

mqole · 2026-03-16T00:27:11Z

Content.Shared/Preferences/HumanoidCharacterProfile.cs

        // TODO: This should eventually not be a visual change only.
-        public static HumanoidCharacterProfile Random(HashSet<string>? ignoredSpecies = null)
+        // MACRO start, extensive changes.
+        public static HumanoidCharacterProfile Random(HashSet<string>? speciesBlacklist = null, bool? characterCreation = true)


Suggested change

public static HumanoidCharacterProfile Random(HashSet<string>? speciesBlacklist = null, bool? characterCreation = true)

public static HumanoidCharacterProfile Random(HashSet<string>? speciesBlacklist = null, bool? characterCreation = true) // MACRO visitor species: add charactercreation

mqole · 2026-03-16T00:28:13Z

Content.Shared/Preferences/HumanoidCharacterProfile.cs


            var species = random.Pick(prototypeManager
                .EnumeratePrototypes<SpeciesPrototype>()
-                .Where(x => ignoredSpecies == null ? x.RoundStart : x.RoundStart && !ignoredSpecies.Contains(x.ID))


comment out instead of deleting
macro start above this line, note that its for visitor species

mqole · 2026-03-16T00:28:35Z

Content.Shared/Preferences/HumanoidCharacterProfile.cs

+            )
+            .ID;


mqole · 2026-03-16T00:28:41Z

Content.Shared/Preferences/HumanoidCharacterProfile.cs

+                    if (characterCreation == true)
+                        return x.RoundStart;
+                    return random.NextFloat() < x.RandomChance && x.RandomViable;
+                })


macro end here

mqole · 2026-03-16T00:28:46Z

Content.Shared/Preferences/HumanoidCharacterProfile.cs


            return RandomWithSpecies(species);
        }
+        // MACRO end


mqole · 2026-03-16T00:30:31Z

Content.Shared/Humanoid/Prototypes/SpeciesPrototype.cs

+    /// <summary>
+    /// Whether or not the species is available for randomization.
+    /// </summary>
+    [DataField]
+    public bool RandomViable { get; private set; }


name of this bool is kind of vague. what does 'randomization' mean in this context?
maybe rename or include in the comment whether or not youre talking about in game or character creation?

mqole · 2026-03-16T00:32:11Z

this pr does also include breaking changes inthat species can now be toggled on or off for visitor exclusive roles i believe

hivehum

test message to see if i got github relay working

fake review

* Costume Bundles + Rearrange AutoDrobe (#1903) This PR adds "costume bundles", a storage item for full costumes in a single bag. Many items in the AutoDrobe have been replaced with their respective costume bundles. You can also equip costume bundles in loadouts. In addition, the AutoDrobe's stock has been completely rearranged, ideally to make things more intuitive. Clown / mime / musician stuff first, then costume bundles, then everything else (roughly grouped by item slot category). Halloween feature. Also, the AutoDrobe's stock was very messy and unintuitive and I felt it was good of a time as any to clean up. New base entity for costume bundles, and then individual bundle prototypes for each costume. Some non-clothing entity prototypes were given a `CostumeItem` tag to allow them to be inserted into costume bundles. Many individual items in AutoDrobe and the theatrical performance crates were replaced with bundles; ultimately, nothing should be actually "lost". Also, rearranged AutoDrobe. A new loadout category, "Costumes", with many costume bundles. You get one. Some bundles have playtime requirements - namely the jester, circus clown, and musician bundles. Added a stupid C# check to prevent a debug assert error related to attempting to set ContainerHeld's fill status before the container has been initialized. No inhands sorry I'm tired Costume bundles: <img width="744" height="616" alt="image" src="https://github.com/user-attachments/assets/2c69b214-4020-46cb-a282-284363c8bbe9" /> Loadouts: <img width="964" height="603" alt="image" src="https://github.com/user-attachments/assets/ada069de-abd6-4c91-8e7b-94628c9d07f6" /> Rearranged AutoDrobe: <details> <summary>Click to expand</summary> <img width="350" height="915" alt="image" src="https://github.com/user-attachments/assets/4c74b69c-cb17-405a-a230-5a0ce96228df" /> <img width="343" height="901" alt="image" src="https://github.com/user-attachments/assets/36ed6de4-d0c7-4c7c-aec5-e5ac4f053e7d" /> <img width="347" height="918" alt="image" src="https://github.com/user-attachments/assets/efc6072f-e503-4929-a2ae-0f43071f43ee" /> <img width="349" height="913" alt="image" src="https://github.com/user-attachments/assets/02fd95b7-e1be-4073-b119-f1125a118a4b" /> <img width="343" height="907" alt="image" src="https://github.com/user-attachments/assets/0a55bac2-4bc2-477d-94cf-e5e1ab5321f4" /> <img width="334" height="965" alt="image" src="https://github.com/user-attachments/assets/47e8d31e-6f25-4f14-9eac-ed8609d14c7f" /> </details> Theatrical Performances Crate: <img width="542" height="507" alt="image" src="https://github.com/user-attachments/assets/514e1daa-ffd6-4828-8447-8d4929e79281" />  - [x] I have read and am following the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html). - [x] I have added media to this PR or it does not require an ingame showcase. - [x] I have tested any changes or additions. - [x] I can confirm this PR contains no AI-generated content, and did not use any AI-generated content.  Only thing is the massive restructure of AutoDrobe inventory and mild rearrangement of the contents of the theatrical performances crate - may cause annoying merge conflicts later **Changelog** :cl: - add: Many individual costume parts in the AutoDrobe and theatrical performances crate have been replaced with "costume bundles", a storage item for costume parts specifically. - tweak: The AutoDrobe's inventory has been majorly consolidated and rearranged. The items inside are sorted by clown, mime, and musician items first, then costume bundles, then everything else. - add: You can now take a costume bundle in your loadouts - find it under Items! You know, in case an occasion that necessitates bringing your own costume arises. * comment out missing costumes * out * this oen actually exists * add costume bundles to autodrobe * and then i rearranged the shit * forgot we on den lol * document costume bundles * add comment * more comments * replace StorageFill with EntityTableContainerFill * replace monkey/performer suits with bundles in theatrical performances crate * summary commment for job costumes * use StorageFillVisualizer instead of ContainerHeld * remove redundant costume icons * i ficked it

honeyed-lemons and others added 5 commits March 13, 2026 19:32

fix comments and kill gingerbread men

bfc2242

fix errors

21a829c

my comments i forgot them.

68e179e

improve logic somewhat, fix comments more

25a7d8e

hivehum previously requested changes Mar 14, 2026

View reviewed changes

Content.Shared/Preferences/HumanoidCharacterProfile.cs Outdated Show resolved Hide resolved

Resources/Prototypes/Species/vox.yml Outdated Show resolved Hide resolved

fix comments

097b552

honeyed-lemons requested a review from hivehum March 14, 2026 03:06

github-actions bot added S: Needs Review size/S labels Mar 14, 2026

mqole requested changes Mar 16, 2026

View reviewed changes

hivehum previously requested changes Mar 16, 2026

View reviewed changes

mqole added Licensed All code in this PR is licensed under MIT with permission obtained from all authors. S: Awaiting Changes and removed S: Needs Review labels Mar 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP Port] Visitor Specific Species#1

[IMP Port] Visitor Specific Species#1
honeyed-lemons wants to merge 6 commits intosyndicate-ss14:masterfrom
honeyed-lemons:visitors

honeyed-lemons commented Mar 13, 2026

Uh oh!

Uh oh!

Uh oh!

mqole Mar 16, 2026

Uh oh!

mqole Mar 16, 2026

Uh oh!

mqole Mar 16, 2026

Uh oh!

mqole Mar 16, 2026

Uh oh!

mqole Mar 16, 2026

Uh oh!

mqole Mar 16, 2026

Uh oh!

mqole Mar 16, 2026

Uh oh!

mqole Mar 16, 2026

Uh oh!

mqole commented Mar 16, 2026

Uh oh!

hivehum left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	var profile = HumanoidCharacterProfile.Random(prototype.SpeciesBlacklist, false); // MACRO
	var profile = HumanoidCharacterProfile.Random(prototype.SpeciesBlacklist, false); // MACRO, added false

	public static HumanoidCharacterProfile Random(HashSet<string>? speciesBlacklist = null, bool? characterCreation = true)
	public static HumanoidCharacterProfile Random(HashSet<string>? speciesBlacklist = null, bool? characterCreation = true) // MACRO visitor species: add charactercreation

Conversation

honeyed-lemons commented Mar 13, 2026

About the PR

Why / Balance

Technical details

Media

Requirements

Breaking changes

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mqole commented Mar 16, 2026

Uh oh!

hivehum left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants