Skip to content

Conversation

@zgz2020
Copy link
Contributor

@zgz2020 zgz2020 commented Feb 15, 2025

Pull Request Title

Adding Phantom wallet support for Playwright

Description

This pull request adds Phantom support for Playwright.

@vercel
Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ❌ Failed (Inspect) Feb 15, 2025 0:13am

/**
* The password of the Phantom wallet.
*/
readonly password: string,

Check warning

Code scanning / CodeQL

Useless assignment to property Warning

This write to property 'password' is useless, since
another property write
always overrides it.
@zgz2020 zgz2020 force-pushed the phantom-playwright branch 3 times, most recently from b341e2d to f20bfd2 Compare February 19, 2025 18:53
@zgz2020 zgz2020 marked this pull request as ready for review February 20, 2025 21:20
@zgz2020 zgz2020 requested a review from drptbl February 20, 2025 21:35
@zgz2020 zgz2020 force-pushed the phantom-playwright branch 8 times, most recently from 480fc87 to dee6e3a Compare February 24, 2025 21:51
@zgz2020 zgz2020 force-pushed the phantom-playwright branch from dee6e3a to 1c7eca0 Compare March 2, 2025 11:23
@zgz2020 zgz2020 force-pushed the phantom-playwright branch 9 times, most recently from 21528c7 to f47a68a Compare March 3, 2025 09:40
@zgz2020 zgz2020 force-pushed the phantom-playwright branch from f47a68a to cb4069d Compare March 3, 2025 10:25
@GyeongChan-Jang
Copy link

GyeongChan-Jang commented Apr 9, 2025

when merge?

@zgz2020 zgz2020 force-pushed the phantom-playwright branch from 447b2d3 to 0f7bf8f Compare May 4, 2025 14:31
@drptbl drptbl merged commit 389ef05 into dev May 4, 2025
6 checks passed
@drptbl drptbl deleted the phantom-playwright branch May 4, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants