Repository navigation
Conversation
|
@quanru is attempting to deploy a commit to the Syntax Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A fresh listener opening an audio link such as
?t=0:01:03can start playback at zero when clicking the main episode Play button. Initialization preloads the episode and marks itLOADED(orPAUSEDfor saved progress), so the page button resumes playback instead of taking its timestamp-aware initial-play path.Changes
INITIALwhile preloading; explicit loads still useLOADED/PAUSED. Add initialization unit regressions.MIDSCENE_E2E_ENABLED=true; model and optional Cloudflare credentials are repository-owned. No model costs or new secrets are required upstream unless maintainers opt in. Reports are downloadable and can optionally be published to Cloudflare Pages with links in Actions Summary.The product fix and test integration are separate commits for independent review. The lockfile expansion is from the three added browser-test dependencies.
Validation
Rebased onto upstream
e7ab8d35and verified revision5c35b1facaaf10c05ce9a175249906648b529ce2:PAUSEDinstead ofINITIAL); restoring the fix passes both initialization tests.gpt-6.1-terra.Scope
Related to #2302, but does not resolve that issue: its report concerns video, while these tests cover audio via the main episode Play button. YouTube playback, audio/video timeline mapping, returning-listener deep links, and starting directly from the bottom player need separate investigation. The bottom control also started at zero during earlier diagnosis and is not claimed fixed here.
The existing fork Playwright PR workflow requires a
DATABASE_URLsecret and previously failed because it was absent. This PR does not claim that every existing fork workflow passes; the new optional CI provisions its own disposable database.