Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #68: Unable to make window smaller (shorter) #87

Closed
wants to merge 1 commit into from

Conversation

onitbot
Copy link
Collaborator

@onitbot onitbot commented Feb 19, 2025

This pull request fixes #68.

The changes made directly address the window resizing issue by:

  1. Setting a minimum height constraint of 200 pixels (via max(200, availableHeight) and max(200, contentHeight)) which ensures the window remains usable while allowing it to be made smaller than before

  2. Reducing the fixed padding from 100 to 40 pixels (- 100 changed to - 40), which provides more usable space for content

  3. Modifying the realHeight calculation logic to properly handle both expanded and collapsed states while respecting the minimum height constraint

  4. The content will now be scrollable within these constraints since the view height can be smaller than the content height

These changes allow users to reduce the window height while maintaining functionality through scrolling, which directly solves the reported issue. The minimum height of 200px ensures the window remains usable even when heavily resized. The implementation is straightforward and uses standard SwiftUI layout principles, making it a robust solution to the reported problem.

Automatic fix generated by OpenHands 🙌

@onitbot onitbot requested a review from jrswanson February 19, 2025 23:44
@jrswanson jrswanson removed their request for review February 19, 2025 23:45
@onitbot onitbot closed this Feb 19, 2025
@onitbot onitbot deleted the openhands-fix-issue-68 branch February 19, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to make window smaller (shorter)
2 participants