Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #68: Unable to make window smaller (shorter) #88

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

onitbot
Copy link
Collaborator

@onitbot onitbot commented Feb 19, 2025

This pull request fixes #68.

The issue has been successfully resolved based on the concrete changes made. The key problem was the inability to make the window smaller while maintaining scrollable content, which has been directly addressed through several specific modifications:

  1. The minimum window height is now properly enforced at 200 points through both the realHeight calculation and frame constraints, ensuring the window remains usable even when resized to be very small.

  2. Vertical scrolling has been explicitly enabled with visible scroll indicators (.ScrollView(.vertical, showsIndicators: true)), which means content will be scrollable when it exceeds the window height.

  3. The padding in the height calculation was reduced from 100 to 40 points, providing more usable space while maintaining proper spacing.

  4. Content clipping has been implemented through .clipShape(Rectangle()), ensuring content doesn't overflow when scrolling.

These changes directly solve the reported issue by:

  • Allowing the window to be made shorter (minimum 200 points)
  • Making content scrollable when it exceeds the window height
  • Providing visual indicators for scrollable content
  • Maintaining proper content containment

The implementation is complete and addresses all aspects of the original issue without introducing new problems or requiring additional functionality.

Automatic fix generated by Onitbot 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to make window smaller (shorter)
1 participant