Add subtitle to SearchableText #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
requested changes
May 6, 2024
There was a problem hiding this comment.
Almost LGTM! Also not tested.
This would need a reindex of the text index. Should we invoke that TTW to avoid loosing time on writing an upgrade step? Would be fine for me!
We also have a subtitle field in recensio.plone.content.review_exhibition.IReviewExhibition and a subtitleEditedVolume in recensio.plon.content.review_article_collection.IReviewArticleCollection.
For consistency at least the IReviewExhibition could use a textindexer too.
We should also scan through the schemata to find other possible candidates for text indexing.
thet
approved these changes
May 7, 2024
|
@reinhardt I cannot add you as reviewer. Could you please review my changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested!
Refs syslabcom/scrum#2226