-
Couldn't load subscription status.
- Fork 121
Add simplefs as new Linux image artifact #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 5 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="README.md">
<violation number="1" location="README.md:114">
The sentence uses the singular verb "is" with the plural subject "other filesystems"; please change it to "are" for correct subject–verb agreement.</violation>
</file>
<file name="mk/external.mk">
<violation number="1" location="mk/external.mk:141">
Pin SIMPLEFS to an immutable tag or commit. Using `master` with a fixed SHA causes the verification step to fail as soon as upstream updates, breaking the build.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
c2942ee to
e80ef96
Compare
|
I like the idea of “eating your own dog food,” and simplefs can be a great demonstration of a minimalist software stack. |
80aca2e to
4b1e7a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 9 files
| # FIXME: mkfs.simplefs is not compilable on macOS, thus running the | ||
| # simplefs cases on Linux runner for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should track this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To enhance the guest OS functionality, this commit integrates the simplefs kernel module to support an additional filesystem. It appends simplefs as a new Linux image artifact and automatically builds the latest simplefs.ko when make build-linux-image is executed. simplefs: https://github.com/sysprog21/simplefs
To reflect the integration of simplefs. simplefs: https://github.com/sysprog21/simplefs
Move Linux artifact-related build commands into the artifact Makefile to improve CI readability and simplify adding new Linux artifacts in the future.
Note: - 7z does not recognize the simplefs format, thus verifying the written files in guestOS's stdout instead of using 7z l in hostOS. - simplefs CI test cases does not run on macOS runner because the mkfs.simplefs cannot be compiled on macOS runner due to platform- specific header(<linux/fs.h>) is included at mkfs.c. [1] Before patching the simplefs upstream, skip the macOS runner for now. [1] https://github.com/sysprog21/simplefs/blob/d7e0c9b6c1e09343ed862c709d3258c22f4a9a83/mkfs.c#L2
4b1e7a2 to
aaa9c44
Compare
|
Thank @ChinYikMing for contributing! |
Description
To enhance the guest OS functionality, this commit integrates the simplefs kernel module to support an additional filesystem. It appends simplefs as a new Linux image artifact and automatically builds the latest simplefs.ko when make build-linux-image is executed.
Testing
# mkdir -p mnt && mount /dev/vdb mnt && insmod mnt/simplefs.ko# mkdir -p simplefs && mount -t simplefs /dev/vda simplefsExpectation
Filesystem commands like cd, touch, ls, mkdir, etc should be operational.
Run
mountand the /dev/vda has filesystem typed simplefs will be shown.Sample output:
Summary by cubic
Add simplefs support by auto-building and packaging simplefs.ko as a Linux image artifact, so the guest OS can mount and use simplefs volumes. README includes brief usage steps.
New Features
Dependencies