Treat <ol> like <ul> when parsing as HTML #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently they still fail because <ul><li>first<li>second</ul> is interpreted as <ul><li>first<li>second</li></li></ul> instead of <ul><li>first</li><li>second</li></ul>
-breakLines outputs "\n>" instead of ">" for the opening tags of elements. This makes it less likely that there will be excessively long lines in the output which break HTML emails - lines longer than 998 chars can be wrapped in a syntactically invalid way. -onlyContents omits the outermost open and close tag, returning only the serialized child nodes (like innerHTML property in a browser). This allows HTML fragments to be generated without having to process the result to strip off the dummy document element wrapper.
…rror, don't add the node or set the result to the nodecmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<ol>
<li>first
<li>second
</ol>
was failing to parse with -html set. This patch adds the <ol> tag to the set that trigger autoclose.
I also added test cases to highlight the incorrect nesting of the <li> child nodes when this doc is parsed.