Fix a bug where if the contents change then it didnt update the UI #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabalinas
reviewed
May 29, 2017
| @@ -187,6 +187,7 @@ | |||
|
|
|||
| (function() { | |||
| var multiselectPrototype = Object.create(HTMLElement.prototype); | |||
| console.log("Hello"); | |||
tabalinas
reviewed
May 29, 2017
| _this._control = _this._root.querySelector('.multiselect'); | ||
| _this._field = _this._root.querySelector('.multiselect-field'); | ||
| _this._popup = _this._root.querySelector('.multiselect-popup'); | ||
| _this._list = _this._root.querySelector('.multiselect-list'); |
There was a problem hiding this comment.
I believe, init block should be extracted to avoid DRY violation. This will also allow us to get rid of _this variable.
|
@PhilAndrew, thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves this problem.
You should use a MutationObserver
https://developer.mozilla.org/en/docs/Web/API/MutationObserver
If the contents of the web component changes, for example the
If I used Javascript to change the contents of this to
Then it should update the displayed data again. So if I use javascript to change the contents then it should update again.