🐛 fixing RequestField and encode_multipart_formdata imports #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @fiorotticaio to sign the Salesforce Inc. Contributor License Agreement. |
|
The label cla:missing is appearing, but I have already authenticated myself in CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, requests "vendorized" urllib3 (and others), and you could import RequestField and encode_multipart_formdata via requests.packages.urllib3....
In recent versions, requests no longer includes urllib3 "inside" itself; it depends on urllib3 installed in the environment.
The requests.packages module is now just a shim, and the type stubs (packages.pyi) don't expose urllib3