feat: retrieve tableau server product name #1631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorwoods
force-pushed
the
jorwoods/detect_server_cloud
branch
from
2c3bdfb to
2ca2847
Compare
Closes tableau#1592 Calls a VizPortal API to retrieve the detailed product name, and attaches it to the TSC.Server object which will make determining what requests to build for things like subscriptions easier. Adds this functionality into the pre-existing `use_server_version` function because: 1. Users of the library will already know to call that method. 2. Users already aware that method makes API calls. If the request errors or if the payload doesn't match the expected format, defaults to assuming TSC is talking with an on-prem Server instance. Co-authored-by: emeric-dsj
jorwoods
force-pushed
the
jorwoods/detect_server_cloud
branch
from
2ca2847 to
52aa4f9
Compare
|
@jacalata Any thoughts regarding this usage of VizPortal to retrieve the product name? It seems to me for some methods, mainly schedules and refreshes, the payload differs substantially enough as to require being handled separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1592
Calls a VizPortal API to retrieve the detailed product name, and attaches it to the TSC.Server object which will make determining what requests to build for things like subscriptions easier. Adds this functionality into the pre-existing
use_server_versionfunction because:If the request errors or if the payload doesn't match the expected format, defaults to assuming TSC is talking with an on-prem Server instance.
Co-authored-by: emeric-dsj