Added new apis to workbook and datasource #1637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Interval-bug Tableau API is expecting an integer or 'lastDay'.
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Vineeth Chavatapalli <v***@s***.com> SFDC\vchavatapalli <v***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
jorwoods
suggested changes
Jul 15, 2025
|
|
||
| @api(version="3.26") | ||
| def update_connections( | ||
| self, datasource_item: DatasourceItem, connection_luids: list[str], authentication_type: str, username: Optional[str] = None, password: Optional[str] = None, embed_password: Optional[bool] = None |
There was a problem hiding this comment.
Should accept an Iterable[ConnectionItem] rather than taking a list of ids and then Connection attributes as keyword args.
|
|
||
| # Update workbook_connections | ||
| @api(version="3.26") | ||
| def update_connections(self, workbook_item: WorkbookItem, connection_luids: list[str], authentication_type: str, username: Optional[str] = None, password: Optional[str] = None, embed_password: Optional[bool] = None |
There was a problem hiding this comment.
Same as datasource method.
|
|
||
| url = f"{self.baseurl}/{datasource_item.id}/connections" | ||
|
|
||
| ts_request = Element("tsRequest") |
There was a problem hiding this comment.
Creating the XML payload belongs in the request_factory.
|
|
||
| def _interval_type_pairs(self): | ||
| return [(IntervalItem.Occurrence.MonthDay, self.interval)] | ||
| return [(IntervalItem.Occurrence.MonthDay, str(day)) for day in self.interval] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.