feat(go): replace custom implemented treemap with gods/v2 treemap #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kybxd
changed the title
wenchy
requested changes
Aug 7, 2024
| @@ -22,7 +22,7 @@ const ( | |||
| loadPackage = protogen.GoImportPath("github.com/tableauio/tableau/load") | |||
| storePackage = protogen.GoImportPath("github.com/tableauio/tableau/store") | |||
| errors = protogen.GoImportPath("github.com/pkg/errors") | |||
| treeMapPackage = protogen.GoImportPath("github.com/tableauio/loader/pkg/treemap") | |||
| treeMapPackage = protogen.GoImportPath("github.com/emirpasic/gods/v2/maps/treemap") | |||
There was a problem hiding this comment.
v2.0 is still not released yet! https://github.com/emirpasic/gods/releases
wenchy
added
the
WaitingForInfo
Kybxd
force-pushed
the
feat/use-gods-treemap-with-generics
branch
from
6bbcebc to
f173de9
Compare
Kybxd
force-pushed
the
feat/use-gods-treemap-with-generics
branch
from
f173de9 to
2413be2
Compare
|
After several years practices in real scenarios, we have learned that we'd better have full control of treemap APIs.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.