Draft
Conversation
yuki-brook
reviewed
Mar 4, 2026
flexkv/external/simm_utils.py
Outdated
|
|
||
| # is this true? | ||
| def _check_success(self, results: List[int], is_set_operate: bool) -> bool: | ||
| return [k_res == 0 if is_set_operate else k_res > 0 for k_res in results] |
There was a problem hiding this comment.
change to [k_res > 0 if is_put_operate else k_res == 0 for k_res in results] will be better
yuki-brook
reviewed
Mar 4, 2026
flexkv/external/simm_utils.py
Outdated
| # is this supported? | ||
| # do we have async delete APIs ? deletion is done in cacheengine, and need to be fast | ||
| def _batch_delete_impl(self, key_strs: List[str]) -> List[int]: | ||
| return self.store.mdelete(key_strs) |
There was a problem hiding this comment.
mdelete is not supported in SiMM now
linhu-nv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.