Chore: cleanup clippy lints #899
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 55.52% 58.54% +3.01%
==========================================
Files 42 42
Lines 15511 15173 -338
==========================================
+ Hits 8613 8883 +270
+ Misses 6898 6290 -608
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
note: the original comment at the top appears not to be caught by the checks. Not sure if that's something to consider..I don't quite know how to fix it, but it appears those structures are a bit out of date at this point. |
| deserialize_num!(deserialize_i128, visit_i128); | ||
| deserialize_num!(deserialize_u128, visit_u128); |
There was a problem hiding this comment.
This change will be done in #908 with necessary bump of the dependency version. It is not required here
| _ if bytes.starts_with(&[0x00, b'<', 0x00, b'?']) => Some((UTF_16BE, 0)), // Some BE encoding, for example, UTF-16 or ISO-10646-UCS-2 | ||
| _ if bytes.starts_with(&[b'<', 0x00, b'?', 0x00]) => Some((UTF_16LE, 0)), // Some LE encoding, for example, UTF-16 or ISO-10646-UCS-2 | ||
| _ if bytes.starts_with(&[b'<', b'?', b'x', b'm']) => Some((UTF_8, 0)), // Some ASCII compatible | ||
| _ if bytes.starts_with(b"<?xm") => Some((UTF_8, 0)), // Some ASCII compatible |
There was a problem hiding this comment.
I prefer to leave it in its current form to keep nice formatting
4 participants
I noticed that some of the tests weren't updated. Specifically this line:
This value may be found in many places, not sure what to do!