Skip to content

952: Increased maximum pool size to 2 in app yml#898

Open
Arshadul-Monir wants to merge 1 commit intomainfrom
952-2
Open

952: Increased maximum pool size to 2 in app yml#898
Arshadul-Monir wants to merge 1 commit intomainfrom
952-2

Conversation

@Arshadul-Monir
Copy link
Copy Markdown
Collaborator

@Arshadul-Monir Arshadul-Monir commented Apr 13, 2026

952

Description of changes

Increased maximum pool size to 2 in app yml

Checklist before review

  • I have done a thorough self-review of the PR
  • Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
  • If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
  • All tests have passed
  • I have successfully deployed this PR to staging
  • I have done manual QA in both dev (and staging if possible) and attached screenshots below.

Screenshots

Dev

Staging

@github-actions
Copy link
Copy Markdown
Contributor

Available PR Commands

  • /ai - Triggers all AI review commands at once
  • /review - AI review of the PR changes
  • /describe - AI-powered description of the PR
  • /improve - AI-powered suggestions
  • /deploy - Deploy to staging

See: https://github.com/tahminator/codebloom/wiki/CI-Commands

@Arshadul-Monir
Copy link
Copy Markdown
Collaborator Author

/deploy

@github-actions
Copy link
Copy Markdown
Contributor

Title

952: Increased maximum pool size to 2 in app yml


PR Type

Enhancement


Description

  • Increased Hikari connection pool size

  • Configured for staging environment


Diagram Walkthrough

flowchart LR
  A["application-stg.yml"] -- "Update `maximum-pool-size`" --> B["Hikari Datasource Configuration"]
Loading

File Walkthrough

Relevant files
Configuration changes
application-stg.yml
Update Hikari connection pool size for staging                     

src/main/resources/application-stg.yml

  • Changed the maximum-pool-size for the spring.datasource.hikari
    configuration from 1 to 2.
  • This update applies specifically to the staging environment.
+1/-1     

@github-actions
Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Notion Task Mismatch

The PR increases the maximum-pool-size from 1 to 2 in application-stg.yml. However, the linked Notion task "Lower max pool size in staging" (ID: 3417c85563aa80eb9075f844671e60b2) indicates the opposite intention. This PR's change directly contradicts the stated goal of the task. Please clarify if the Notion task title or the PR's change is correct.

maximum-pool-size: 2

datasource:
hikari:
maximum-pool-size: 1
maximum-pool-size: 2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: A maximum-pool-size of 2 for the HikariCP connection pool in the staging environment is likely too low and could become a significant performance bottleneck. This can lead to connection starvation and increased latency during concurrent operations. Consider increasing this value to a more appropriate default (e.g., 10-20) to ensure the staging environment can handle expected load. [general, importance: 8]

Suggested change
maximum-pool-size: 2
maximum-pool-size: 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant