You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR increases the maximum-pool-size from 1 to 2 in application-stg.yml. However, the linked Notion task "Lower max pool size in staging" (ID: 3417c85563aa80eb9075f844671e60b2) indicates the opposite intention. This PR's change directly contradicts the stated goal of the task. Please clarify if the Notion task title or the PR's change is correct.
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: A maximum-pool-size of 2 for the HikariCP connection pool in the staging environment is likely too low and could become a significant performance bottleneck. This can lead to connection starvation and increased latency during concurrent operations. Consider increasing this value to a more appropriate default (e.g., 10-20) to ensure the staging environment can handle expected load. [general, importance: 8]
Suggested change
maximum-pool-size: 2
maximum-pool-size: 10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
952
Description of changes
Increased maximum pool size to 2 in app yml
Checklist before review
Screenshots
Dev
Staging